fix: build_data_writer.ps1 encoding and ACLs

[rickeylev]

Windows Powershell APIs have several quirks that can make a file problematic if
typical Linux semantics are assumed

• BOM header bytes can be written, which break regular UTF8 parsing
• The file can be left open, which prevents later deletion of it
• The files can be written with limited permissions, leading to permission errors later.

To fix, use alternative Powershell APIs for writing the text file. Also explicitly set
permissions on the output.

I came across this when Windows starting running the build data tests in non-zip mode,
where the original file permissions are kept.

[gemini-code-assist]

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build_data_writer.ps1 script by addressing critical issues related to file encoding and access permissions. The changes ensure that the generated output file is consistently formatted and accessible, improving the reliability and compatibility of the build process.

Highlights

• File Encoding: The script now uses .NET's System.IO.File::WriteAllLines method to write content to the output file, explicitly specifying UTF8 encoding without a Byte Order Mark (BOM). This resolves potential PowerShell encoding quirks and ensures compatibility with consumers expecting a specific format.
• Access Control Lists (ACLs): Read access is now explicitly granted to 'Everyone' on the generated output file. This prevents potential permission issues when other processes or users attempt to read the file.
• Improved Robustness: Added Test-Path checks before attempting to read content from $VersionFilePath and $InfoFilePath, preventing errors if these optional files do not exist.
• Code Refactoring: The script now collects all lines of content into an array ($Lines) before performing a single write operation, improving efficiency and readability compared to multiple Add-Content calls.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• python/private/build_data_writer.ps1
  • Updated file writing mechanism to use .NET's System.IO.File::WriteAllLines for explicit UTF8 No-BOM encoding.
  • Implemented logic to set 'Everyone' read permissions on the output file using Set-Acl.
  • Refactored content aggregation into an array before writing to the file.
  • Added Test-Path checks for $VersionFilePath and $InfoFilePath to prevent errors if files are missing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the build_data_writer.ps1 script to address file encoding and permissions issues on Windows. The change from multiple Add-Content calls to a single [System.IO.File]::WriteAllLines call is a good improvement for performance and correctly handles UTF-8 encoding without a BOM. The addition of ACL modifications to grant read access is a reasonable approach to solve permission problems in a build environment. However, I have one suggestion to enhance security by using a more restrictive permission set.