Fix installer for GoReleaser archives - #193
Closed
robzolkos wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the scripts/install.sh curl-based installer to download and verify the GoReleaser-produced, versioned release archives (instead of raw binaries), then extract and install the fizzy executable across all published OS/arch targets.
Changes:
- Switch download target to
fizzy_<version>_<os>_<arch>.{tar.gz|zip}and validate it against the sharedchecksums.txt. - Add platform-aware SHA-256 verification using available native tools (
sha256sum,shasum,sha256, oropenssl). - Extract archives (tarballs and Windows zip) prior to copying the binary into the install directory; add FreeBSD/OpenBSD + Windows ARM64 support.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+84
to
+88
| if [ "$ARCHIVE_FORMAT" = "zip" ]; then | ||
| if ! command -v unzip >/dev/null 2>&1; then | ||
| echo "ERROR: unzip is required to install Fizzy on Windows" | ||
| exit 1 | ||
| fi |
Collaborator
Author
|
Resolved in #194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
checksums.txtWhy
The v4 installer requested unversioned raw binaries and per-platform checksum files, but the release publishes versioned archives and one shared checksum file. As a result, the documented curl installer returned a 404 for v4.0.0.
Testing
GOWORK=off make checkpassesbash -n scripts/install.shpassesgit diff --checkpassesSummary by cubic
Fixes the v4 curl installer by downloading versioned GoReleaser archives, verifying them against the shared checksum file, and extracting before install. This removes the 404 error and adds support for Windows ARM64, FreeBSD, and OpenBSD.
checksums.txt.sha256sum,shasum,sha256, oropenssl.Written for commit 57bc31e. Summary will update on new commits.