fix: add HOST_IP support to nethermind entrypoint#1046
Open
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Open
fix: add HOST_IP support to nethermind entrypoint#1046mehmetkr-31 wants to merge 1 commit intobase:mainfrom
mehmetkr-31 wants to merge 1 commit intobase:mainfrom
Conversation
The geth entrypoint already supports HOST_IP via --nat=extip, but the nethermind entrypoint ignores it entirely. This causes peer connectivity issues for operators running the nethermind client. Add the same conditional logic to pass --Network.ExternalIp when HOST_IP is set, aligning nethermind behavior with geth.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
HOST_IPsupport to the nethermind execution client entrypoint, matching the existing behavior in the geth entrypoint.Problem
The
geth-entrypointscript already respects theHOST_IPenvironment variable and passes--nat=extip:$HOST_IPto improve peer discoverability. However, thenethermind-entrypointcompletely ignoresHOST_IP, causing operators who choose the nethermind client to have worse peer connectivity.Solution
Add the same conditional check (
if [ "${HOST_IP:+x}" = x ]) to the nethermind entrypoint and append--Network.ExternalIp=$HOST_IPtoADDITIONAL_ARGS.Impact
Checklist
geth-entrypoint.