proposal: Add visual PFM packets for annotate gate#1005
Open
leoreisdias wants to merge 5 commits into
Open
Conversation
639b7aa to
0120e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR explores a Plannotator-native version of the richer visual planning experience that tools like Agent-Native make feel so useful: a plan can be more than a wall of markdown, with file maps, diagrams, callouts, checklists, questions, and reviewable structure.
The important boundary here is that this is inspiration, not runtime compatibility. The source stays Plannotator Flavored Markdown, the renderer uses constrained built-in PFM directives, and visual packets still move through the existing
plannotator annotate --gate <file-or-folder>workflow instead of introducing a new public command or MDX/React component execution surface.This can land as a first concept if the direction feels right, while leaving room for follow-up work: more custom PFM blocks, a future extension contract for user-defined blocks, and eventually a visual review mode alongside Code Tour that reuses the same PFM component vocabulary.
What Changed
calloutfile-mapdiagramchecklistopen-questionsannotated-diffcode-walkthroughplannotator-visual-planextra skill to author PFM visual plan packets and open them with annotate gate.Screenshots
I am leaving these slots open intentionally so we can paste screenshots from the generated test packet before marking this ready for review.
For a local visual smoke test, open pfm-kitchen-sink.md with
plannotator annotate --gate pfm-kitchen-sink.md; it exercises the current visual PFM blocks in one packet.Callout
File Map
Diagram
Checklist
Open Questions
Annotated Diff
Code Walkthrough
Review Focus
plannotator-visual-planshould be treated as an optional extra skill, not a new default command surface.Future Work This Enables
Test Plan
bun test --timeout 15000 apps/hook/server/cli.test.ts apps/hook/server/annotate-outcome.test.ts packages/server/annotate.test.ts packages/shared/agent-terminal.test.ts apps/pi-extension/server.test.tsbun test apps/skills/extra/plannotator-visual-plan/SKILL.test.ts packages/server/annotate.test.ts packages/ui/components/BlockRenderer.visual.test.tsx scripts/install.test.tsbash apps/pi-extension/vendor.sh && node node_modules/.bun/typescript@5.8.3/node_modules/typescript/bin/tsc --noEmit -p packages/shared/tsconfig.json && node node_modules/.bun/typescript@5.8.3/node_modules/typescript/bin/tsc --noEmit -p packages/ai/tsconfig.json && node node_modules/.bun/typescript@5.8.3/node_modules/typescript/bin/tsc --noEmit -p packages/server/tsconfig.json && node node_modules/.bun/typescript@5.8.3/node_modules/typescript/bin/tsc --noEmit -p packages/ui/tsconfig.json && node node_modules/.bun/typescript@5.8.3/node_modules/typescript/bin/tsc --noEmit -p apps/pi-extension/tsconfig.jsonbun run build:hookbun build apps/hook/server/index.ts --target=bun --define "__CLI_VERSION__=\"0.0.0-test\"" --outfile /tmp/plannotator-hook-server-test.js