Skip to content

[feat] JS腳本預先支援月之七聖遺物秘境更新+新增發出BGI通知#3224

Open
RJFAC wants to merge 7 commits into
babalae:mainfrom
RJFAC:main
Open

[feat] JS腳本預先支援月之七聖遺物秘境更新+新增發出BGI通知#3224
RJFAC wants to merge 7 commits into
babalae:mainfrom
RJFAC:main

Conversation

@RJFAC
Copy link
Copy Markdown
Contributor

@RJFAC RJFAC commented May 20, 2026

新增BGI通知
新增月之七版本圣遗物秘境山风的荆冕
等待BGI本体传送点更新

Summary by CodeRabbit

v0.11 版本发布说明

  • 新功能

    • 新增"山风的荆冕"秘境及其对应圣遗物掉落数据支持
    • 增强脚本通知系统,提供更详细的任务执行反馈和耗时统计
    • 扩展圣遗物选项列表,支持更多圣遗物选择
  • 更新

    • 版本号更新至 v0.11

Review Change Stack

RJFAC added 5 commits April 11, 2026 20:55
* 调整战斗策略设置方式
* 在显示日志中新增说明
* 读我文件排版
* 调试模式新增显示传入参数
修正刷完樹脂模式的邏輯
修正刷完模式的文字描述
新增BGI通知
新增月之七版本圣遗物秘境山风的荆冕
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 41137a85-6204-4d1c-a96b-41fad1ff8a65

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

概述

此 PR 为 AutoDomainCustomizable 脚本版本 0.11 添加了通知系统,用于在秘境选择、任务完成和异常处理时向用户反馈实时信息,并扩展了秘境与圣遗物配置数据以支持"山风的荆冕"秘境。

变更内容

自动秘境脚本 v0.11 版本更新

图层 / 文件 说明
版本更新与通知系统实现
manifest.json, main.js
manifest.json 版本从 0.10 升级至 0.11,BGI 版本要求提升至 0.60.1;main.js 头部新增 safeNotify(type, message) 函数,根据通知类型调用 notification.Error 或 notification.Send,并对失败情况进行容错日志记录。
秘境数据与圣遗物配置扩展
Genshin_Domains_SC_Live_Source.json, settings.json
Genshin_Domains_SC_Live_Source.json 的 artifacts 列表末尾新增"山风的荆冕"秘境条目,包含两件掉落物品;settings.json 在 TargetArtifactName 选项的挪德卡莱分组末尾追加对应的两条可选项。
脚本逻辑中的通知集成
main.js
在秘境目标自动切换、圣遗物模式排程提示、任务完成耗时统计、战斗脚本文件缺失重试提示、自动匹配脚本失败中断告警、背包满/秘境结束检测失败等异常处理中,分别调用 safeNotify("info", ...) 或 safeNotify("error", ...) 提供用户反馈。
文档与更新日志更新
README.md
日志预设位置说明更新为反引号格式;v0.11 变更日志新增 BGI 通知功能和月之七版本新秘境"山风的荆冕"两条记录。

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

可能相关的 PR

  • babalae/bettergi-scripts-list#3108:两个 PR 都在 main.js 中"找不到/不存在战斗策略文件"的降级重试分支进行改动,此 PR 新增 safeNotify 告警,而该 PR 重构了 catch 路径逻辑。

🐰 新秘境来临山风起,
通知漫天如星指;
脚本善言告用户心,
版本更新显真意。
v0.11,前行无阻!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确反映了PR的主要变更:新增BGI通知功能和支持月之七版本圣遗物秘境'山风的荆冕',与各文件的实际修改内容相符。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RJFAC
Copy link
Copy Markdown
Contributor Author

RJFAC commented May 20, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@repo/js/AutoDomainCustomizable/Genshin_Domains_SC_Live_Source.json`:
- Around line 237-241: 将当前对象中的错误名称替换为官方 6.0 简体中文:把 domain_name_sc 从 "山风的荆冕" 改为
"纺月穹境",并把 drops 数组从 ["天之美赐", "影中沉凝的幻灭"] 改为 ["纺月的夜歌"];如果你还需要代表另一个秘境("穹境示现之夜" → 掉落
["穹境示现之夜"]),请新增一个独立对象而不是合并到同一条目(请修改 domain_name_sc 和 drops 字段以定位和修正)。

In `@repo/js/AutoDomainCustomizable/main.js`:
- Line 2: 更新文件头的修改日期注释以反映实际 PR 创建日期;在 repo/js/AutoDomainCustomizable/main.js
找到注释行 "// Modified Date: 2026-04-20" 并将日期更新为 "2026-05-20"(或实际修改日期),以确保注释与 PR
时间一致并避免误导。
- Around line 6-18: In safeNotify(), the code calls the wrong notification API
method name; replace the undefined call to notification.Error(message) with the
correct notification.error(message) (keep the existing branch logic and error
handling in safeNotify so log.warn(...) remains unchanged).

In `@repo/js/AutoDomainCustomizable/README.md`:
- Line 148: Replace the phrase "新增月之七版本圣遗物秘境山风的荆冕" with the readability-improved
title form "新增月之七版本圣遗物秘境「山风的荆冕」" in the README entry (the line containing the
original string) so the proper name is wrapped in Chinese book title marks for
clearer proper-name boundaries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 787083c4-64f7-4441-b1f9-4339407bc8f5

📥 Commits

Reviewing files that changed from the base of the PR and between d00d4ed and 4762b39.

📒 Files selected for processing (5)
  • repo/js/AutoDomainCustomizable/Genshin_Domains_SC_Live_Source.json
  • repo/js/AutoDomainCustomizable/README.md
  • repo/js/AutoDomainCustomizable/main.js
  • repo/js/AutoDomainCustomizable/manifest.json
  • repo/js/AutoDomainCustomizable/settings.json

Comment thread repo/js/AutoDomainCustomizable/Genshin_Domains_SC_Live_Source.json
Comment thread repo/js/AutoDomainCustomizable/main.js Outdated
Comment thread repo/js/AutoDomainCustomizable/main.js
Comment thread repo/js/AutoDomainCustomizable/README.md Outdated
RJFAC added 2 commits May 20, 2026 16:04
更新修改日期
增強可讀性
@RJFAC
Copy link
Copy Markdown
Contributor Author

RJFAC commented May 20, 2026

已修正完成,可以直接合併,或等本體AutoDomain新增月之七秘境傳點後一同合併,謝謝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant