Repository navigation
fix(train): refresh the entity's own version in DataSet and Evaluator - #6426
Open
AkshayShah03 wants to merge 1 commit into
Open
AkshayShah03 wants to merge 1 commit into
AkshayShah03 wants to merge 1 commit into
Conversation
DataSet.refresh() and Evaluator.refresh() called describe_hub_content without a version, unlike the base AIRHubEntity.refresh(), so DescribeHubContent returned the latest version and overwrote the object with it. Calling refresh() or wait() on an older version (e.g. one from get_versions()) silently turned it into the latest version, and wait() polled the latest version's status instead of its own. Pass self.version to describe_hub_content in both overrides.
AkshayShah03
requested a deployment
to
manual-approval
October 10, 2026 02:01 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
AkshayShah03
requested a deployment
to
manual-approval
October 10, 2026 02:01 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The base
AIRHubEntity.refresh()describes the entity's own version. TheDataSet.refresh()andEvaluator.refresh()overrides calldescribe_hub_contentwithout a version, soDescribeHubContentreturns the latest version, and they overwrite the object with it, includingversion,arn,source/referenceandstatus.As a result,
refresh()on an older version (for example one returned byget_versions()) silently turns it into the latest version.wait(), which pollsrefresh(), waits on the latest version's status instead of its own.This change passes
hub_content_version=self.versionin both overrides.Testing:
TestDataSetRefreshVersionandTestEvaluatorRefreshVersion. Both fail before this change.sagemaker-train/tests/unit/ai_registry: 98 passed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.