fix(train): load Nova hyperparameters file in ModelTrainer - #6144
Open
saisharan0103 wants to merge 1 commit into
Open
fix(train): load Nova hyperparameters file in ModelTrainer#6144saisharan0103 wants to merge 1 commit into
saisharan0103 wants to merge 1 commit into
Conversation
…arameters from file for Amazon Nova Recipe Closes aws#5770
saisharan0103
requested a deployment
to
manual-approval
August 1, 2026 18:50 — with
GitHub Actions
Waiting
saisharan0103
requested a deployment
to
manual-approval
August 1, 2026 18:50 — with
GitHub Actions
Waiting
saisharan0103
requested a deployment
to
manual-approval
August 1, 2026 18:50 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5770.
ModelTrainer.from_recipehas a Nova-specific path that handles stringhyperparametersvalues as file paths. That branch calledcls._validate_and_load_hyperparameters_file(...), butModelTraineronly defines_validate_and_fetch_hyperparameters_file(...). As a result, Nova recipes using a hyperparameters file path raisedAttributeErrorbefore the file could be validated, parsed, and merged with recipe-derived hyperparameters.This replaces the erroneous call with the existing
_validate_and_fetch_hyperparameters_filehelper.A focused unit regression test now creates a temporary Nova recipe and temporary hyperparameters file, calls
ModelTrainer.from_recipewithhyperparametersset to that file path, and asserts the parsed values are present intrainer.hyperparameterswithout raisingAttributeError.Existing dict-hyperparameters and non-Nova behavior are unchanged.
ruff check sagemaker-train/src/sagemaker/train/model_trainer.py sagemaker-train/tests/unit/train/test_model_trainer.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.