Merged
Conversation
Instead of using expectDeprecation now we use expectException but we do use the set_error_handler to throw that expected exceptions when expecting warnings or user notices.
Enhance data providers within test cases to avoid the usage of instance members since they become now static functions.
- expectWarning, expectError, expectError, etc. were removed in PHPUnit 10, and a workaround was used in order to replace the usage of those APIs. The replacement is to use set_error_handler to catch the alert, throw a RuntimeException, and then expect this thrown exception.
- Remove constructor override for TestCase extension. - Remove CoverClass from methods.
yenfryherrerafeliz
force-pushed
the
chore_php_unit_10
branch
from
ef2a511 to
ac41a42
Compare
stobrien89
requested changes
Feb 18, 2026
Member
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
Looks good for the most part, mostly minor things that are easy to miss in such a large PR
stobrien89
reviewed
Feb 19, 2026
- Add the attribute DoesNotPerformAssertions instead of CoversNothing - Remove assertTrue from tests that do not perform assertions - Make one leftover data provider function static - Fixed retry logic in ComposerTest so it properly test retries scenarios after removing onConsecutiveCalls usage.
We already have a dedicated workflow for coverage and hence we dont need this on our tests run workflow. Also, this will slowdown the test run process.
stobrien89
requested changes
Mar 9, 2026
Member
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
Looks good! Just needs a rebase for the merge conflicts
stobrien89
approved these changes
Mar 10, 2026
Member
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
Thanks for the work on this @yenfryherrerafeliz!
Contributor
Author
|
Update integ tests to avoid extending TestCase and use Assert:: instead.
stobrien89
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.