Skip to content

test: add integration tests for CLI client#8689

Open
reedham-aws wants to merge 3 commits intoaws:feat-buildkitfrom
reedham-aws:buildkit-tests-integ
Open

test: add integration tests for CLI client#8689
reedham-aws wants to merge 3 commits intoaws:feat-buildkitfrom
reedham-aws:buildkit-tests-integ

Conversation

@reedham-aws
Copy link
Contributor

Integration test PR for buildkit/container CLI support.

Added a few parameterized tests for some image based tests, as well as just general tests for using the --use-buildkit flag. Worth noting is that when using the CLI, there were a lot of resource warnings that the sockets were being left open. I couldn't figure out a fix to this, but I think they're harmless warnings so I ignored them.

Implementation PR: #8661.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added area/local/start-api sam local start-api command area/build sam build command area/local/invoke sam local invoke command area/local/start-invoke area/schema JSON schema file pr/internal labels Feb 24, 2026
@reedham-aws reedham-aws marked this pull request as ready for review February 24, 2026 01:31
@reedham-aws reedham-aws requested a review from a team as a code owner February 24, 2026 01:31
@roger-zhangg
Copy link
Member

prob need to merge from develop for the chardet thing

Copy link
Member

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would suggest to add a ARM64 test, and then mark one test -> x86/arm64 as https://github.com/aws/aws-sam-cli/blob/develop/CONTRIBUTING.md#tier-1-cross-platform-smoke-tests for running that test on finch / windows (to be added)

@reedham-aws
Copy link
Contributor Author

would suggest to add a ARM64 test, and then mark one test -> x86/arm64 as https://github.com/aws/aws-sam-cli/blob/develop/CONTRIBUTING.md#tier-1-cross-platform-smoke-tests for running that test on finch / windows (to be added)

Done, I added as tier1, although not sure if this would have fallen more into the tier1_extra category. I think the testing of the CLI is important enough, not sure about the parameters.

@reedham-aws
Copy link
Contributor Author

reedham-aws commented Feb 27, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build sam build command area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke area/schema JSON schema file pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants