Skip to content

feat(emr): Improve SSH host key verification with accept-new#10390

Merged
AndrewAsseily merged 1 commit into
aws:developfrom
JasonLEE327:emr-ssh-accept-new
Jun 11, 2026
Merged

feat(emr): Improve SSH host key verification with accept-new#10390
AndrewAsseily merged 1 commit into
aws:developfrom
JasonLEE327:emr-ssh-accept-new

Conversation

@JasonLEE327

Copy link
Copy Markdown
Contributor

EMR SSH/SCP helper commands (ssh, socks, put, get) now default to StrictHostKeyChecking=accept-new for improved host key verification. Uses ssh -G probe to detect support; falls back to =no with warning on OpenSSH < 7.6.

New --ssh-options parameter allows passing arbitrary SSH options (space-separated) to override defaults. This provides an escape hatch for legacy clients and addresses #1799.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@JasonLEE327 JasonLEE327 requested a review from a team as a code owner June 10, 2026 03:49
@AndrewAsseily

Copy link
Copy Markdown
Contributor

Looks like CI's failing on this. Could you check the failed jobs and push a fix?

@JasonLEE327 JasonLEE327 force-pushed the emr-ssh-accept-new branch 3 times, most recently from dfb43a7 to 88ac1e9 Compare June 10, 2026 18:34
EMR SSH/SCP helper commands (ssh, socks, put, get) now default to
StrictHostKeyChecking=accept-new for improved host key verification.
Uses ssh -G probe to detect support; falls back to =no with warning
on OpenSSH < 7.6.

New --ssh-options parameter allows passing arbitrary SSH options
(space-separated) to override defaults. This provides an escape hatch
for legacy clients and addresses aws#1799.

References: P413905599, V2174489182
@codecov-commenter

codecov-commenter commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.34043% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.61%. Comparing base (c4681b5) to head (a89ae39).
⚠️ Report is 429 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/customizations/emr/ssh.py 72.34% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10390      +/-   ##
===========================================
+ Coverage    93.39%   93.61%   +0.22%     
===========================================
  Files          210      211       +1     
  Lines        17052    17358     +306     
===========================================
+ Hits         15925    16249     +324     
+ Misses        1127     1109      -18     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewAsseily AndrewAsseily left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndrewAsseily AndrewAsseily merged commit 170cfc7 into aws:develop Jun 11, 2026
41 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jun 11, 2026
* release-1.45.28:
  Bumping version to 1.45.28
  Update changelog based on model updates
  Merge customizations for EKS
  feat(emr): Improve SSH host key verification with accept-new (#10390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants