Added DRS example files#10308
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10308 +/- ##
===========================================
+ Coverage 93.39% 93.43% +0.04%
===========================================
Files 210 211 +1
Lines 17052 17283 +231
===========================================
+ Hits 15925 16149 +224
- Misses 1127 1134 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdaily
left a comment
There was a problem hiding this comment.
Lots of new docs, nice!
Few things to check, see inline comments.
Also, check for the formatting of recovery instance IDs in these files (and maybe more?): disconnect-recovery-instance.rst, stop-failback.rst, get-failback-replication-configuration.rst, reverse-replication.rst, start-failback-launch.rst, terminate-recovery-instances.rst, and update-failback-replication-configuration.rst. Looks like recovery instance ID uses s-1234567890abcdef0. Do actual DRS recovery instance IDs use i- prefix (EC2 instance IDs)?
The describe-recovery-instances.rst output correctly shows "recoveryInstanceID": "i-1234567890abcdef0" and "ec2InstanceID": "i-1234567890abcdef0", but the commands using --recovery-instance-id pass in s-1234567890abcdef0.
Co-authored-by: Kenneth Daily <kdaily@amazon.com>
Co-authored-by: Kenneth Daily <kdaily@amazon.com>
|
Also note the failing CI test, there seems to be a missing required parameter to one of the example commands: https://github.com/aws/aws-cli/actions/runs/27447126863/job/81134513239?pr=10308#step:5:975 |
*Issue #, if available: Internal docs feedback ticket
*Description of changes: Added a directory for DRS and added the provided examples files. Manually checked that these examples render correctly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.