Conversation
karenc-bq
force-pushed
the
feat/gdb-iam
branch
4 times, most recently
from
8cf1954 to
c58c8ac
Compare
| } | ||
|
|
||
| this.region = RegionUtils.getRegion(props.get(WrapperProperties.CUSTOM_ENDPOINT_REGION.name), this.customEndpointHostInfo.host); | ||
| const regionUtils = new RegionUtils(); |
There was a problem hiding this comment.
Curious, is custom endpoint plugin incompatible with global? This doesn't seem to allow it to use the gdb region utils
There was a problem hiding this comment.
Good point, let's add the feature to custom endpoints as well
There was a problem hiding this comment.
Discussed this further offline and decided to keep this unchanged.
We will not reach this section of the code unless the URL is a custom endpoints URL. Custom endpoints URL contains proper region information, so there is no need to retrieve region information using GDBRegionUtils here.
| const rdsClient = this.getRdsClient(); | ||
|
|
||
| try { | ||
| const command = new DescribeGlobalClustersCommand({ |
There was a problem hiding this comment.
If we get an sdk error e.g. permission issues, will this propagate?
There was a problem hiding this comment.
I will wrap the error but I am leaning towards failing-fast here
3 participants
Summary
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.