feat: add semantic search toggle for gateways#533
Merged
Conversation
Add enableSemanticSearch boolean (default true) to AgentCoreGatewaySchema. When enabled, the service indexes tool descriptions for natural language discovery. Update LLM-compacted types and add schema validation tests.
Allow callers to specify pre-selected items and ensure reset() restores initial selections instead of clearing to empty set.
… wizard Add 'advanced-config' step to the gateway creation TUI wizard with a toggleable checkbox for semantic search (enabled by default). Replace static AUTHORIZER_NEXT_STEP map with dynamic routing to fix navigation when unassigned targets exist.
Wire enableSemanticSearch through GatewayPrimitive, CLI option types, and the useCreateGateway hook so both TUI and CLI paths persist the setting to mcp.json.
notgitika
previously approved these changes
Mar 11, 2026
Contributor
notgitika
left a comment
notgitika
left a comment
There was a problem hiding this comment.
left some nits but otherwise this looks great to me!
Rename noSemanticSearch to enableSemanticSearch in primitive options and hoist initialSelectedIds array to module-level constant to avoid new reference on every render.
tejaskash
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds semantic search support for gateways. When enabled (the default), the AgentCore service indexes tool descriptions across all gateway targets, providing agents with a built-in search tool for natural language tool discovery. This is especially useful when a gateway has many targets with dozens of tools each.
Changes:
enableSemanticSearchboolean field (defaulttrue) toAgentCoreGatewaySchema[✓] Semantic Search Enabled). Defaults to checked. Space toggles, Enter confirms.--no-semantic-searchoption toagentcore add gatewayfor non-interactive usageinitialSelectedIdssupport touseMultiSelectNavigationso toggle lists can start with pre-selected itemsAUTHORIZER_NEXT_STEPmap with dynamic routing that correctly handles theinclude-targetsstep when unassigned targets existCompanion CDK PR: https://github.com/aws/agentcore-l3-cdk-constructs/pull/75
Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsNew tests added:
truewhen omitted, explicittrue/falseaccepted, non-boolean rejecteduseMultiSelectNavigationtests (3):initialSelectedIdspre-selects items, toggling off works,reset()restores initial selectionsManual verification:
agentcore add gatewayTUI flow end-to-end, confirmed advanced config pane renders correctly with toggle and confirm screen shows semantic search status--no-semantic-searchCLI flag writesenableSemanticSearch: falseto mcp.jsontrue(backward compatible)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.