fix(commons): don't overwrite existing value with undefined in deepMerge#5141
Merged
svozza merged 3 commits intoaws-powertools:mainfrom Mar 27, 2026
Conversation
Same behaviour as `lodash.merge`: Source properties that resolve to `undefined` are skipped if a destination value exists.
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
svozza
changed the title
undefinedundefined
Contributor
|
Thank you for the PR! Looks good, only one small issue with the Sonarqube finding. Once we fix that, we're good to merge. |
dreamorosi
reviewed
Mar 27, 2026
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
Contributor
|
@svozza I committed the change to address the Sonar finding - it's ready to approve & merge |
dreamorosi
changed the title
undefinedundefined in deepMerge
svozza
approved these changes
Mar 27, 2026
Contributor
|
Sweet. Approved! |
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Contributor
|
Nice work @faberchri, all merged now! |
faberchri
deleted the
fix/5138-handling-of-undefined-in-deep-merge-utility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
deepMergeutility function to maintain the following behaviour oflodash.merge: Source properties that resolve toundefinedare skipped if a destination value exists.Changes
deepMergeutility and unit tests updatedIssue number: closes #5138
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.