Optional update encrypted attributes only when values changed#301
Open
twanmaus wants to merge 24 commits intoattr-encrypted:masterfrom
Open
Optional update encrypted attributes only when values changed#301twanmaus wants to merge 24 commits intoattr-encrypted:masterfrom
twanmaus wants to merge 24 commits intoattr-encrypted:masterfrom
Conversation
…utes Optional update encrypted attributes only when values changed
|
This is awesome - would be great to see this merged! 👍 |
…l instances of a given class due to shallow dup. This caused random OpenSSL::Cipher::CipherError errors, particularly in cases in which concurrent encrypts/decrypts were occurring.
Fix concurrency problem
Contributor
|
This seems to duplicate #284 However, I'm leaning more towards this approach. |
Support ActiveRecord 5.2
Use GitHub Actions for CI.
Rails 6.0
Remove DataMapper.
Add Rails 6.1 + Ruby 3.0/3.1 to CI
Rename encrypt/decrypt methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all encrypted attributes are updated each time the record is saved. This means that also unchanges values are encrypted again. When creating an audit log for changed attributes this is unwanted behaviour.
This pull request makes it is possible to change this default behaviour and encrypt only the changed attributes again.