Refactor AsgardeoReactClient initialization to fix the type issue#437
Open
NipuniBhagya wants to merge 3 commits intoasgardeo:mainfrom
Open
Refactor AsgardeoReactClient initialization to fix the type issue#437NipuniBhagya wants to merge 3 commits intoasgardeo:mainfrom
NipuniBhagya wants to merge 3 commits intoasgardeo:mainfrom
Conversation
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the initialization logic of the
AsgardeoReactClientto improve how theperiodicTokenRefreshconfiguration is handled. The main change is moving the logic for settingperiodicTokenRefreshfrom theinitializeConfigassignment to the object passed directly to theasgardeo.initcall, ensuring the correct value is always used during initialization.Configuration handling improvements:
periodicTokenRefreshfrom theinitializeConfigproperty to the argument passed toasgardeo.init, ensuring that the most up-to-date value is used during initialization.Checklist
Security checks