Skip to content

Refactor AsgardeoReactClient initialization to fix the type issue#437

Open
NipuniBhagya wants to merge 3 commits intoasgardeo:mainfrom
NipuniBhagya:main
Open

Refactor AsgardeoReactClient initialization to fix the type issue#437
NipuniBhagya wants to merge 3 commits intoasgardeo:mainfrom
NipuniBhagya:main

Conversation

@NipuniBhagya
Copy link
Copy Markdown
Contributor

Purpose

This pull request updates the initialization logic of the AsgardeoReactClient to improve how the periodicTokenRefresh configuration is handled. The main change is moving the logic for setting periodicTokenRefresh from the initializeConfig assignment to the object passed directly to the asgardeo.init call, ensuring the correct value is always used during initialization.

Configuration handling improvements:

  • Moved the logic for determining periodicTokenRefresh from the initializeConfig property to the argument passed to asgardeo.init, ensuring that the most up-to-date value is used during initialization.

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

@asgardeo-github-bot
Copy link
Copy Markdown

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants