-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Enable Ubuntu Resolute image build #9164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdds per-variant config symlink files for resolute and questing that point to shared common paths, adds a 56-line package list for each variant, and comments out an APA auto-enable conditional in lib/functions/configuration/main-config.sh. Changes
Sequence Diagram(s)(omitted — changes are small config redirections and a minor script tweak, not a multi-component control-flow feature) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (6)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-06-22T00:45:26.182ZApplied to files:
📚 Learning: 2025-10-24T04:46:22.901ZApplied to files:
🔇 Additional comments (4)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@leggewie Does the plan still include APA? |
|
No, it's not linked. |
|
I'm ashamed to admit, but I don't understand everything that is done with apa at all. |
|
What I was told back around November was that |
high-level overview: |
|
It seems wrong to me to inherit a new version of ubuntu directly from debian if ubuntu is available. |
|
I don't exactly disagree, except that if |
|
I understand. |
|
While I agree that 1) we should enable resolute without APA 2) remove the traces of APA until that initiative produces some actual benefit that justifies it's inclusion; I do think we need to enable building on Resolute before targetting Resolute. |
yes. but, and I admit this is an ass-umption, we won't certify it before our own |
|
Add Not stopping from any works for future enhancements and reworks. Please |
|
@iav agree 100%. Out of curiosity, how did you determine the contents of the new files? Did you simply copy one of the existing ones and it worked? Things added or removed? This shows how we could instead of the APA fiasco, replace the aggregation (using those crazy files/symlinks) with simple bash code and a few helpers and be able to express in a few lines "Resolute is the same as X, minus Z" and gain the power of extensions/hooks on top for free. |
I just copied the files. |
|
Yes, and I don't see any problem in just replacing the symlink with a regular copy of the file exactly at the very moment when we find that it's time to change the file that was still working as a symlink. |
7bb1135 to
2d5525b
Compare
|
So... having had a discussion with @igorpecovnik |
|
we can of course revert #8969 separately |
Definitely, it will be clearer and cleaner separately. |
Sorry, I didn't understand. |
2d5525b to
18fc481
Compare
|
My thought here was that reverting #8969 isn't enough... we want to disable APA for |
|
Would you like me to prepare a PR with #8969 reverted and the remaining line commented out? |
18fc481 to
de00e23
Compare
sounds reasonable. |
df6065c to
498ff45
Compare
done |
minor nit: the commit message should say "Disable APA" not "ATF" |
…esolute builds. Closes: armbian#8966" This reverts commit ca73176.
e4c3969 to
0ec7488
Compare
tabrisnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
✅ This PR has been reviewed and approved — all set for merge! |
Enable Ubuntu Resolute image build.
Copy file structure from
config/cli/resolutetoconfig/cli/noble.Undo APA (#9164 (comment)).
How Has This Been Tested?
Build edge, current images for noble, resolute, trixie
./compile.sh EXPERT=yes BOARD=helios64 KERNEL_CONFIGURE=no BUILD_MINIMAL=yes KERNEL_BTF=no KERNEL_GIT=shallow INSTALL_HEADERS=yes RELEASE=trixie BRANCH=current
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.