feat(btrfs): add compression scheme selection for subvolumes - #4673
Open
Erox-02 wants to merge 1 commit into
Open
feat(btrfs): add compression scheme selection for subvolumes#4673Erox-02 wants to merge 1 commit into
Erox-02 wants to merge 1 commit into
Conversation
Author
|
Collaborator
|
You changed the formatting of the edited files can you please revert that |
Author
|
Ok i shall patch it by tomorrow |
Author
|
@svartkanin PR ready for review. All merge conflicts resolved - kept master's formatting/arch changes and my BtrfsCompression changes. Tested and working. Thanks! |
Collaborator
|
Please remove the AI comments. I'll not spent time reviewing code that you have not reviewed yourself. |
Author
|
@svartkanin I've rechecked my code , updated to newest merge and removed the comments , ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to choose compression scheme for BTRFS subvolumes
What this PR does
Adds user-selectable compression for BTRFS subvolumes during installation.
BtrfsCompressionenum with lzo and zstd:1-19 optionscompressionfieldCurrently users can't choose compression algorithm (hardcoded to zstd:3).
Different use cases need different balances of speed vs compression.
Testing
chattr +capplied#2681 fixed
issue closed