Skip to content

feat: add x oauth provider to console#2966

Merged
HarshMN2345 merged 1 commit intomainfrom
feat-add-x-provider
Apr 8, 2026
Merged

feat: add x oauth provider to console#2966
HarshMN2345 merged 1 commit intomainfrom
feat-add-x-provider

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

image image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 8, 2026

Greptile Summary

This PR adds X (formerly Twitter) as a new OAuth2 provider in the console by registering a new x entry in oAuthProviders, adding matching X logo SVGs, and removing the now-orphaned Twitter bird SVGs. It also fixes a reactivity bug in the auth settings page: data.project was previously destructured as a static snapshot; it is now $derived so that invalidate(Dependencies.PROJECT) correctly triggers re-renders.

Confidence Score: 4/5

Safe to merge; changes are additive and self-contained. The only external dependency is that the Appwrite backend exposes an OAuth provider with key x.

All code changes are minimal and low-risk: a new record in a static map, four SVG icon swaps, and a one-line reactivity fix. No logic paths are removed or altered in a breaking way. Score is 4 rather than 5 because the feature's end-to-end correctness depends on the backend returning key: "x" in project.oAuthProviders, which is a cross-repo dependency not verified in this PR.

No files require special attention; cross-repo backend alignment is the only remaining concern.

Vulnerabilities

No security concerns identified. The new OAuth provider entry uses an HTTPS docs URL and delegates authentication flow to the existing Main component, which is already used by the majority of providers.

Important Files Changed

Filename Overview
src/lib/stores/oauth-providers.ts Adds new x provider entry between wordpress and yahoo with correct icon, docs URL, and Main component; alphabetical order is preserved.
src/routes/(console)/project-[region]-[project]/auth/settings/+page.svelte Changes const { project } = data to $derived(data.project) so the variable stays reactive after invalidate(Dependencies.PROJECT) calls — a correct Svelte 5 runes fix.
static/icons/dark/color/x.svg New X logo SVG (20×20, white fill #F7F8F8) replacing the deleted Twitter bird SVG; size matches the img element's height="20" width="20" in the page template.
static/icons/light/color/x.svg New X logo SVG (20×20, dark fill #0F1419) replacing the deleted Twitter bird SVG for the light theme.
static/icons/dark/grayscale/x.svg New X logo grayscale SVG (20×20) for dark theme, replacing deleted Twitter grayscale SVG.
static/icons/light/grayscale/x.svg New X logo grayscale SVG (20×20) for light theme, replacing deleted Twitter grayscale SVG.

Reviews (1): Last reviewed commit: "feat: add x oauth provider to console" | Re-trigger Greptile

@HarshMN2345 HarshMN2345 requested a review from eldadfux April 8, 2026 17:35
@HarshMN2345 HarshMN2345 merged commit 8c227f8 into main Apr 8, 2026
3 of 4 checks passed
@HarshMN2345 HarshMN2345 deleted the feat-add-x-provider branch April 8, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants