Conversation
Pass progress to Upload.Box for real-time progress bars on storage file uploads. Add onProgress callbacks and percentage display to the file picker modal used by CSV/JSON import.
Greptile SummaryThis PR wires up real-time upload progress feedback across two upload surfaces: the storage Key changes:
Confidence Score: 5/5Safe to merge — all remaining findings are P2 style/UX suggestions that do not block functionality. The core progress-tracking logic is correct and consistent with existing patterns in the uploader store. Both P2 comments (desktop button progress % and Cancel button UX) are improvements, not blockers. No P0/P1 issues found. src/lib/components/filePicker.svelte — minor inconsistency in progress display and Cancel button UX
|
| Filename | Overview |
|---|---|
| src/lib/components/filePicker.svelte | Adds uploadProgress variable and onProgress callbacks to both createFile paths; shows percentage in footer Select button and small-viewport Upload button; disables Cancel + Select during upload and prevents modal dismissal. Two minor issues: desktop inline Upload button omits the progress %, and disabling Cancel leaves no escape from an in-progress upload. |
| src/lib/components/uploadBox.svelte | Passes file.progress through to Upload.Box so the storage upload progress bar renders correctly; depends on the updated @appwrite.io/pink-svelte bump in package.json. |
| package.json | Bumps @appwrite.io/pink-svelte to 8dcaa17 (adds progress prop to Upload.Box, satisfying the declared dependency) and @appwrite.io/console to 467cd21 (exposes onProgress on createFile). |
Reviews (3): Last reviewed commit: "fix: prevent modal dismiss during upload..." | Re-trigger Greptile
- Disable Cancel button and set dismissible=false on Modal during upload - Update @appwrite.io/pink-svelte to 8dcaa17 (progress bar a11y fixes)
Summary
progresstoUpload.Boxfor real-time progress bars on storage file uploadsonProgresscallbacks to file picker'screateFilecalls used by CSV/JSON importDependencies
progressprop toUpload.Boxcomponent)Upload Progress in Import CSV

Upload Progress in buckets add file
