Skip to content

fix: prevent sending empty title or body in push messages #2904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bhaaru2 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: prevent sending empty title or body in push messages #2904

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3ca948
fix: prevent sending empty title or body in push messages
bhargavi2568 Mar 8, 2026
ad62e16
fix: allow saving drafts while validating push message fields
bhargavi2568 Mar 8, 2026
7f018f4
fix: reset draft state and trim inputs before sending push messages
bhargavi2568 Mar 8, 2026
a314c4b
fix: avoid overriding undefined draft fields when trimming inputs
bhargavi2568 Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/routes/(console)/project-[region]-[project]/messaging/create-[type]/(type)/push.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@
let scheduledAt: string;

async function create() {
if (!title?.trim() || !body?.trim()) {
addNotification({
type: 'error',
message: 'Title and message body cannot be empty.'
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
});
return;
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
try {
const messageId = id || ID.unique();
const fileCompoundId = file ? `${file.bucketId}:${file.$id}` : undefined;
Expand Down