fix: Add is_finished and align is_empty semantics in ApifyRequestQueueClient#1008
Open
Mantisus wants to merge 4 commits into
Open
fix: Add is_finished and align is_empty semantics in ApifyRequestQueueClient#1008Mantisus wants to merge 4 commits into
is_finished and align is_empty semantics in ApifyRequestQueueClient#1008Mantisus wants to merge 4 commits into
Conversation
vdusek
requested changes
Jun 23, 2026
vdusek
reviewed
Jun 25, 2026
vdusek
reviewed
Jun 25, 2026
vdusek
left a comment
vdusek
left a comment
Contributor
There was a problem hiding this comment.
Could we also use a fix here please? Same reason as explained here apify/crawlee-python#1982 (review)
Claude suggests one of these:
- fix: prevent RQ softlock by correcting is_empty in ApifyRequestQueueClient
- fix: add is_finished and align is_empty semantics in ApifyRequestQueueClient
I am ok with both of them
Mantisus
changed the title
is_finished method in the ApifyStorageClientis_finished and align is_empty semantics in ApifyRequestQueueClient
vdusek
reviewed
Jun 26, 2026
vdusek
left a comment
vdusek
left a comment
Contributor
There was a problem hiding this comment.
Let's get back to this, once Crawlee 1.8.0 is released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
is_finishedand alignis_emptysemantics inApifyRequestQueueClientCloses: #987
Follow-up: apify/crawlee-python#1982