-
Notifications
You must be signed in to change notification settings - Fork 4
feat: enable ginkgo parallel execution for API7EE E2E tests #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -34,7 +34,7 @@ ADC_VERSION ?= 0.22.1 | |||||||||||||
|
|
||||||||||||||
| DIR := $(shell pwd) | ||||||||||||||
|
|
||||||||||||||
| GINKGO_VERSION ?= 2.20.0 | ||||||||||||||
| GINKGO_VERSION ?= 2.22.0 | ||||||||||||||
| TEST_TIMEOUT ?= 80m | ||||||||||||||
| TEST_DIR ?= ./test/e2e/ | ||||||||||||||
| E2E_NODES ?= 4 | ||||||||||||||
|
|
@@ -154,6 +154,13 @@ download-api7ee3-chart: | |||||||||||||
| ginkgo-e2e-test: adc | ||||||||||||||
| @ginkgo -cover -coverprofile=coverage.txt -r --randomize-all --randomize-suites --trace --focus=$(E2E_FOCUS) --nodes=$(E2E_NODES) --label-filter="$(TEST_LABEL)" $(TEST_DIR) | ||||||||||||||
|
|
||||||||||||||
| .PHONY: ginkgo-api7ee-e2e-test | ||||||||||||||
| ginkgo-api7ee-e2e-test: adc | ||||||||||||||
| @DASHBOARD_VERSION=$(DASHBOARD_VERSION) ginkgo -cover -coverprofile=coverage.txt \ | ||||||||||||||
| --randomize-all --randomize-suites --trace \ | ||||||||||||||
| --timeout=$(TEST_TIMEOUT) --nodes=$(E2E_NODES) \ | ||||||||||||||
| --label-filter="$(TEST_LABEL)" ./test/e2e/ | ||||||||||||||
|
AlinsRan marked this conversation as resolved.
|
||||||||||||||
|
|
||||||||||||||
| .PHONY: install-ginkgo | ||||||||||||||
| install-ginkgo: | ||||||||||||||
| @go install github.com/onsi/ginkgo/v2/ginkgo@v$(GINKGO_VERSION) | ||||||||||||||
|
Comment on lines
164
to
166
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo 'Makefile install-ginkgo target:'
sed -n '164,166p' Makefile
echo
printf 'go env GOBIN: %s\n' "$(go env GOBIN)"
printf 'go env GOPATH: %s\n' "$(go env GOPATH)"
gopath_bin="$(go env GOPATH)/bin"
case ":$PATH:" in
*":$gopath_bin:"*)
echo "PATH already contains $gopath_bin"
;;
*)
echo "PATH does NOT contain $gopath_bin"
;;
esacRepository: api7/api7-ingress-controller Length of output: 301 🏁 Script executed: #!/bin/bash
# Verify Makefile context
echo "=== Line 37 (GINKGO_VERSION) ==="
sed -n '35,40p' Makefile
echo
echo "=== Lines 157-162 (ginkgo-api7ee-e2e-test target) ==="
sed -n '155,165p' Makefile
echo
echo "=== Lines 379-380 (PATH export) ==="
sed -n '375,385p' Makefile
echo
echo "=== LOCALBIN definition ==="
rg 'LOCALBIN\s*:?=' Makefile | head -5
echo
echo "=== All ginkgo-related targets ==="
rg '\.PHONY:.*ginkgo|^[a-z-]*ginkgo[a-z-]*:' MakefileRepository: api7/api7-ingress-controller Length of output: 1348 🏁 Script executed: #!/bin/bash
# Find LOCALBIN definition and go-install-tool function
echo "=== Searching for LOCALBIN definition ==="
rg 'LOCALBIN\s*:?=' Makefile -B 2 -A 2
echo
echo "=== Searching for go-install-tool function ==="
rg -A 10 'define go-install-tool|go-install-tool\s*=' Makefile
echo
echo "=== First 100 lines of Makefile (looking for variable definitions) ==="
head -100 Makefile | cat -n | tail -50Repository: api7/api7-ingress-controller Length of output: 2808 🏁 Script executed: #!/bin/bash
# More comprehensive search for LOCALBIN
echo "=== Entire Makefile search for LOCALBIN ==="
rg 'LOCALBIN' Makefile -B 1 -A 1
echo
echo "=== Line count of Makefile ==="
wc -l MakefileRepository: api7/api7-ingress-controller Length of output: 2048 Install the Ginkgo CLI into The Suggested fix .PHONY: install-ginkgo
install-ginkgo:
- `@go` install github.com/onsi/ginkgo/v2/ginkgo@v$(GINKGO_VERSION)
+ `@GOBIN`=$(LOCALBIN) go install github.com/onsi/ginkgo/v2/ginkgo@v$(GINKGO_VERSION)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.