operation openapi property support#430
Merged
soyuka merged 9 commits intoapi-platform:mainfrom Jan 28, 2026
Merged
Conversation
Contributor
Author
|
UPDATE: no longer relevant, all green About failed checks:
Please let me know, to not to put unnecessary work into it making backward compatibility (its mostly about method named arguments). After all it is for Api Platform Core 4.0.
|
PawelSuwinski
force-pushed
the
openapi-attr-support
branch
from
5146f57 to
ea27046
Compare
PawelSuwinski
changed the title
Contributor
Author
|
RFR, WDYT @dunglas ? |
Contributor
Author
|
Hi, @soyuka/ @dunglas can we merge this or please can you give some feedback/ review? Checks solved, all green. |
dunglas
requested changes
Feb 27, 2025
Member
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Hey, sorry for the time we took to review.
The approach looks good to me overall, but I left some comments to make the code more readable.
Contributor
Author
|
All fixed, thanks for PR. |
Contributor
Author
|
Hi @dunglas, can we merge this then? |
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
soyuka
force-pushed
the
openapi-attr-support
branch
from
fa0bfaf to
1828a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operation
openapiContextproperty is deprecated and will be removed in Api Platform Core 4.0.This PR allows transparent migration to
openapiproperty,s/openapiContext:/openapi:/should be enough in a schema.yaml file.Resolve #427