Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
aaa2000
commented
Feb 3, 2026
vincentchalamon
requested changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Shouldn't the symfony.lock be updated too?
E2E tests because of the following error:
PHP Fatal error: Uncaught Error: Class "Runtime\FrankenPhpSymfony\Runtime" not found in /app/vendor/autoload_runtime.php:19\nStack trace:\n#0 /app/public/index.php(7): require_once()\n#1 {main}\n thrown in /app/vendor/autoload_runtime.php on line 19
aaa2000
commented
Feb 4, 2026
This comment was marked as resolved.
This comment was marked as resolved.
aaa2000
force-pushed
the
sf8
branch
8 times, most recently
from
f97c24f to
721d1d0
Compare
aaa2000
force-pushed
the
sf8
branch
2 times, most recently
from
fee192b to
1e10d76
Compare
soyuka
reviewed
Feb 16, 2026
Member
soyuka
left a comment
soyuka
left a comment
There was a problem hiding this comment.
awesome work thanks! I kinda did the same for foundry in my branch but I'll wait for this to get merged all rollback there.
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # api/composer.lock
1) App\Tests\Api\Admin\BookTest::asAdminUserICanGetACollectionOfBooks@books filtered by author with data (Zenstruck\Foundry\FactoryCollection Object (...), '/admin/books?author=simmons', 1) Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing a query: SQLSTATE[23502]: Not null violation: 7 ERROR: null value in column "book" of relation "book" violates not-null constraint DETAIL: Failing row contains (019c6092-2957-7394-8fe5-c0c567bf6aab, null, null, Dan Simmons, https://schema.org/RefurbishedCondition).
[ERROR] Could not process
"/app/tests/Serializer/IriTransformerNormalizerTest.php" file, due to:
"System error: "Attempt to assign property "type" on null"
This comment was marked as resolved.
This comment was marked as resolved.
vincentchalamon
force-pushed
the
sf8
branch
3 times, most recently
from
ff3f27d to
aca2eaa
Compare
Contributor
|
@aaa2000 branch rebased, e2e tests fixed (and some additional stuffs). Do you still have some work to do on this PR, or can I merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.