ZOOKEEPER-5052: Fix stale thread write of primitive in JvmPauseMonitor#2397
Merged
Merged
Conversation
Change the three counter fields to volatile to ensure cross-thread visibility when the getters are called from threads other than the monitor thread. This prevents the JVM caching the stale 0 value. Under CI load or with aggressive JIT optimizations, this manifests as an intermittent 5-second timeout.
dsmiley
approved these changes
May 27, 2026
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
+1 Looks like a simple issue; thanks
anmolnar
approved these changes
Jun 16, 2026
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Jun 16, 2026
Reviewers: dsmiley, imankhadiv, anmolnar Author: PDavid Closes #2397 from PDavid/ZOOKEEPER-5052-JvmPauseMonitor (cherry picked from commit 9dd41cd) Signed-off-by: Andor Molnar <andor@cloudera.com>
Contributor
Author
|
Many thanks @dsmiley, @imankhadiv and @anmolnar for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the three counter fields to volatile to ensure cross-thread visibility when the getters are called from threads other than the monitor thread.
This prevents the JVM caching the stale 0 value. Under CI load or with aggressive JIT optimizations, this manifests as an intermittent 5-second timeout.