[HOTFIX] Dedupe minimatch and bump postcss in zeppelin-react - #5352
Merged
Conversation
tbonelee
approved these changes
Jul 27, 2026
Contributor
|
Merged into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The
npm-auditjob fails on master with seven high findings, all indevDependencies:brace-expansion <=5.0.7, GHSA-mh99-v99m-4gvg (DoS via unbounded expansion)postcss <=8.5.17, GHSA-r28c-9q8g-f849 (path traversal in source map auto-loading)minimatch@10.2.5is already hoisted at the top ofzeppelin-react's tree. The vulnerablebrace-expansion@1.1.16comes from four nested copies ofminimatch@3.1.5, undereslint,@eslint/eslintrc,@eslint/config-arrayandeslint-plugin-react. Anoverridesentry forminimatchcollapses those onto the version already present, removingminimatch@3from the tree, andbrace-expansionthen moves 5.0.7 to 5.0.8.postcssmoves 8.5.15 to 8.5.23 in the lockfile (npm audit fix, nopackage.jsonchange;nanoidfollows as its dependency). That is the same bump as #5341, which this supersedes.The result is
found 0 vulnerabilities. The gate itself is unchanged: still--audit-level=highover the full dependency tree, sodevDependencieskeep their CI coverage.Upgrading the eslint side is not an alternative here.
eslint-plugin-react@7.37.5is the latest release, declaresminimatch@^3.1.2itself, and does not run on eslint 10 (TypeError: contextOrFilename.getFilename is not a functionatlib/util/version.js:31), so no version bump removes the nested copy. Overridingbrace-expansionalone does not work either, because 5.0.8 drops the CJS default export thatminimatch@3.1.5calls, which gives a green audit andTypeError: expand is not a functionon lint. Overriding both avoids that, sinceminimatch@10does not use the removed export.The lockfile shrinks by 129 lines, dropping the four nested
minimatch/brace-expansion/balanced-matchtrees andconcat-map.What type of PR is it?
Hot Fix
Todos
What is the Jira issue?
How should this be tested?
The
npm-auditjob on this PR. Locally, from a deletednode_modulesinzeppelin-web-angular/projects/zeppelin-react:Screenshots (if appropriate)
Questions: