[ZEPPELIN-6426] Remove redundant eslint-disable comments in zeppelin-web-angular#5264
Open
tbonelee wants to merge 4 commits into
Open
[ZEPPELIN-6426] Remove redundant eslint-disable comments in zeppelin-web-angular#5264tbonelee wants to merge 4 commits into
tbonelee wants to merge 4 commits into
Conversation
voidmatcha
approved these changes
Jun 4, 2026
Contributor
voidmatcha
left a comment
voidmatcha
left a comment
There was a problem hiding this comment.
Suggestion: add linterOptions: { reportUnusedDisableDirectives: 'error' } to eslint.config.js so this stays enforced by default it's only a warning and ng lint never fails on warnings.
LGTM
Co-authored-by: YONGJAE LEE (이용재) <dev.yongjaelee@gmail.com>
Set linterOptions.reportUnusedDisableDirectives to 'error' in zeppelin-web-angular/eslint.config.js so eslint-disable directives that no longer suppress anything fail `ng lint` instead of only warning. The flat-config default is 'warn' and `ng lint` exits 0 on warnings, so without this the redundant directives removed in this change would silently accumulate again over time; promoting to error keeps the cleanup enforced by default. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Assisted-By: Claude <noreply@anthropic.com>
…react Mirror the root zeppelin-web-angular change in the zeppelin-react sub-app's eslint.config.js by setting linterOptions.reportUnusedDisableDirectives to 'error', so eslint-disable directives that no longer suppress anything fail `npm run lint:react` instead of only warning. The flat-config default is 'warn' and plain `eslint` (no --max-warnings) exits 0 on warnings, so without this stale directives would silently accumulate in the React sources too; this keeps both sub-apps consistent. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Assisted-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Thanks @voidmatcha! Added it in 746751d, and applied the same to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
zeppelin-web-angular has several eslint-disable comments that no longer suppress any violation under the current ESLint configuration (e.g. no-invalid-this, id-blacklist, no-eval, jsdoc/no-types, @typescript-eslint/naming-convention, @angular-eslint/component-class-suffix). These unused directives are misleading and add noise, so this PR removes them. No functional change.
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
npm run lintin zeppelin-web-angular and confirm it still passes.Questions: