[Script] Make transpiler call helper keywords explicit - #20448
Merged
Merged
Conversation
tlopex
approved these changes
Sep 25, 2026
tqchen
force-pushed
the
explicit-call-helper-keywords
branch
from
September 25, 2026 11:31
93a6966 to
9c4c766
Compare
tqchen
force-pushed
the
explicit-call-helper-keywords
branch
from
September 25, 2026 13:05
4dc1905 to
82cc5ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transpiler call helpers currently mix builder arguments and source-location metadata in variadic keyword dictionaries. Make the builder keyword mapping optional and explicit, with dedicated keyword-only parameters for
span,name_span, andvalue_span.Update callers to separate builder arguments from source ranges while preserving their evaluation order and leaving caller-owned mappings unchanged. This is a readability cleanup.