fix(cpp): aligned VECTOR row-offset skip only when time/value counts …#778
Merged
jt2594838 merged 1 commit intoapache:developfrom Apr 12, 2026
Merged
Conversation
…match Whole-chunk and whole-page skips by statistic count previously used only the value side for aligned series, which could desynchronize row_offset from decoded rows when ChunkMeta or page header counts differed. Require both time and value statistics to be present, positive, and equal before applying count-based skip; otherwise decode and rely on page/row handling. Made-with: Cursor
jt2594838
approved these changes
Apr 12, 2026
ycycse
pushed a commit
to ycycse/tsfile
that referenced
this pull request
Apr 12, 2026
…match (apache#778) Whole-chunk and whole-page skips by statistic count previously used only the value side for aligned series, which could desynchronize row_offset from decoded rows when ChunkMeta or page header counts differed. Require both time and value statistics to be present, positive, and equal before applying count-based skip; otherwise decode and rely on page/row handling. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whole-chunk and whole-page skips by statistic count previously used only the value side for aligned series, which could desynchronize row_offset from decoded rows when ChunkMeta or page header counts differed.
Require both time and value statistics to be present, positive, and equal before applying count-based skip; otherwise decode and rely on page/row handling.