Add state transition diagram of StripeSM#12791
Merged
masaori335 merged 1 commit intoapache:masterfrom Feb 3, 2026
Merged
Conversation
masaori335
commented
Jan 8, 2026
|
|
||
| note bottom of aggWriteDone | ||
| calls aggWrite() directly | ||
| without changing state |
Contributor
Author
There was a problem hiding this comment.
This is a pitfall. Change the state back to aggWrite before calling it seems better to me.
bryancall
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No code change. Add a plantuml diagram as a comment to describe state transition of StripeSM.