-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add configurable compression #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
markt-asf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing the PR. It has been very thought provoking.
I think we need to look at more than just GZip. Other compression algorithms are available and I think we need a more generic approach. I don't think we should be setting algorithm specific settings in the Protocol. I also don't think they should be set on CompressionCongfig. Speaking of CompressionConfig, are the new getters there used? I looked but couldn't see any calls to them.
I think we might need a new server.xml element for output compression (and possibly one for input compression too). With attributes for className, encoding and algorithm specific attributes. It should be possible to override the default gzip support.
The handling of custom InputFilters might provide some inspiration for OutputFilters.
There are some elements of the PR that can be used as is. I'll start cherry-picking those shortly.
This can be used to control which content encodings will not be compressed when compression is enabled. Based on pull request #914 by Long9725.
This can be used to control which content encodings will not be compressed when compression is enabled. Based on pull request #914 by Long9725.
This can be used to control which content encodings will not be compressed when compression is enabled. Based on pull request #914 by Long9725.
This can be used to control which content encodings will not be compressed when compression is enabled. Based on pull request #914 by Long9725.
Make compression pluggable and configurable (gzip level/buffer), retain API compatibility
Overview
Changes
delegating to gzip.
setNoCompressionEncodings.
Influence