THRIFT-6021: Make C++ HTTP client work with oneway requests#3514
Draft
kpumuk wants to merge 1 commit into
Draft
Conversation
Member
|
Somehow that sounds weird. Also, assumed I do a lot of oneway calls, what would be the performance impact? |
Member
Author
Oh for sure it is undeniably weird. The PR is mostly to gather ideas on how to address it, and which side must handle :-) Here is an example: https://github.com/kpumuk/thrift/actions/runs/26243739717/job/77238383058 . From |
Member
Author
|
I highly suspect that these are related too:
|
Member
Author
|
Java suffers from the same issue https://github.com/kpumuk/thrift/actions/runs/26251658457/job/77265909596: |
Member
Author
|
Alright, I think there are 2 bugs:
Will see how to fix it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When making a
onewayRPC call, HTTP client closes the HTTP connection so the unread HTTP response cannot poison the next RPC.Caution
HTTP client does not really have a semantics of "fire and forget", so this is the simplest (but maybe a bit drastic) measure. Maybe calling
readMoreData(); readEnd()would make more sense?[skip ci]anywhere in the commit message to free up build resources.