Evaluate authorization for requests that carry no principal - #9005
Merged
Conversation
reiabreu
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleACLAuthorizer.permitandSupervisorSimpleACLAuthorizer.permitdereferencedcontext.principal()directly, so a request that carries no principal ended in aNullPointerExceptioninstead of an authorization decision. Over the UI this surfaced as HTTP 500 rather than 403.Both now read the principal defensively, the way
SimpleWhitelistAuthorizerandDRPCSimpleACLAuthorizeralready do.IPrincipalToLocal.toLocal(Principal)is null-safe already.Behaviour
No decision logic changes. A request without a principal simply follows the rules that were already written: it matches no admin, supervisor or nimbus entry; it keeps the allow-all behaviour when
nimbus.usersandnimbus.groupsare both empty; and it is denied as soon as a list is configured or a topology-level ACL applies.Testing
mvn -pl storm-client test -DskipITs— 661 tests, 0 failuresmvn -pl storm-server test -DskipITs— 490 tests, 0 failures