Check the calling principal against the topology owner in uploadNewCredentials - #9001
Merged
Conversation
reiabreu
approved these changes
Aug 23, 2026
rzo1
force-pushed
the
fix/nimbus-credentials-owner-check
branch
from
August 24, 2026 08:16
1489679 to
67a36d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner check read its expected value from
credentials.get_topoOwner(), i.e. from data the caller supplied, and never compared it to the caller own principal. The exception text ("is expected to be owned by X but is actually owned by Y") shows a caller-equals-owner binding was intended.The expected owner is now derived from the authenticated principal. Extends
NimbusTest.Behaviour change:
storm upload-credentials -u <owner> <topology>run by anyone other than the owner now fails, including members of the topologytopology.users/topology.groupsandnimbus.admins. Please say if you would rather keep an admin exemption.