[SPARK-56332][SQL][TESTS] Use sql.SparkSession in trait SQLTestData#55162
Open
zhengruifeng wants to merge 4 commits intoapache:masterfrom
Open
[SPARK-56332][SQL][TESTS] Use sql.SparkSession in trait SQLTestData#55162zhengruifeng wants to merge 4 commits intoapache:masterfrom
sql.SparkSession in trait SQLTestData#55162zhengruifeng wants to merge 4 commits intoapache:masterfrom
Conversation
… SQLTestData Use `sql.SparkSession` instead of `classic.SparkSession` in `SQLTestData`. For datasets that require RDD-based creation (emptyTestData, testData, testData2, testData3, upperCaseData, lowerCaseData, lowerCaseDataWithDuplicates), cast to `classic.SparkSession`. For all other datasets, use `spark.createDataFrame` directly. Co-authored-by: Isaac
Replace `.toDF()` on RDDs with `spark.createDataFrame(rdd)` and `$"..."` with `col("...")` to eliminate the SQLImplicits dependency.
Co-authored-by: Isaac
This reverts commit 1cf5903.
Replace `.toDF()` on RDDs with `spark.createDataFrame(rdd)` and `$"..."` with `col("...")` to eliminate the SQLImplicits dependency.
Co-authored-by: Isaac
hvanhovell
reviewed
Apr 2, 2026
| protected lazy val emptyTestData: DataFrame = { | ||
| val df = spark.sparkContext.parallelize( | ||
| Seq.empty[Int].map(i => TestData(i, i.toString))).toDF() | ||
| val df = spark.createDataFrame( |
Contributor
There was a problem hiding this comment.
Can you please avoid using SparkContext.parallelize?
val df = spark.emptyDataset[TestData].toDF()
hvanhovell
reviewed
Apr 2, 2026
| val df = spark.sparkContext.parallelize( | ||
| (1 to 100).map(i => TestData(i, i.toString))).toDF() | ||
| val df = spark.createDataFrame( | ||
| spark.asInstanceOf[classic.SparkSession].sparkContext.parallelize( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
sql.SparkSessionintrait SQLTestDataWhy are the changes needed?
this is needed for merging SQLTestUtils and QueryTest
Does this PR introduce any user-facing change?
No, test-only
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
Co-authored-by: Claude code (Opus 4.6)