[SPARK-56329][PYTHON] Fix all E721 type comparison violations#55150
Closed
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-56329][PYTHON] Fix all E721 type comparison violations#55150zhengruifeng wants to merge 1 commit intoapache:masterfrom
zhengruifeng wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @gaogaotiantian can you help review? this change was suggested by AI and I remember we discussed this before |
Contributor
|
If we want to do this, remove |
zhengruifeng
force-pushed
the
fix-isinstance-pandas-types
branch
from
143ff27 to
d4e925f
Compare
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
force-pushed
the
fix-isinstance-pandas-types
branch
from
d4e925f to
349d015
Compare
Contributor
Author
|
@gaogaotiantian please take another look |
gaogaotiantian
approved these changes
Apr 3, 2026
Replace all `type(x) == SomeType` with `isinstance(x, SomeType)` and remove E721 from pyproject.toml ignore list. Co-authored-by: Isaac
zhengruifeng
force-pushed
the
fix-isinstance-pandas-types
branch
from
349d015 to
c3cba34
Compare
Contributor
Author
|
thanks, merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix all E721 (
type-comparison) violations across the PySpark codebase and remove E721 from thepyproject.tomlruff ignore list.Why are the changes needed?
E721 was ignored in
pyproject.tomlwith a TODO comment ("too many for now"). This PR fixes all 78 violations across 24 files so the rule can be enforced going forward.Changes:
type(x) == SomeType→isinstance(x, SomeType)type(x) != SomeType→not isinstance(x, SomeType)type(x) == type(y)/type(x) != type(y)→type(x) is type(y)/type(x) is not type(y)type(x) in [A, B]→isinstance(x, (A, B))variant_type == dict→variant_type is dict(type-identity comparisons)Does this PR introduce any user-facing change?
No
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
Co-authored-by: Claude code (Opus 4.6)