Skip to content

SolrIndexSearcher is retained for the life of the node by OpenTelemetry observable gauges - #4902

Draft
mkhludnev wants to merge 2 commits into
apache:mainfrom
mkhludnev:copilot/analyze-leak-issue
Draft

SolrIndexSearcher is retained for the life of the node by OpenTelemetry observable gauges#4902
mkhludnev wants to merge 2 commits into
apache:mainfrom
mkhludnev:copilot/analyze-leak-issue

Conversation

@mkhludnev

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/SOLR-18442

Description

Please provide a short description of the changes you're making with this pull request.

Solution

Please provide a short description of the approach taken to implement your solution.
We appreciate transparent disclosure of significant AI Coding assistants usage.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

Copilot AI and others added 2 commits September 10, 2026 22:08
Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
assertU(adoc("id", "1000000", "field1_s", "foo"));
openNewSearcherAndWait();

assertEventuallyReleased(replacedSearcher);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too heavy test. Put it into Nightly or drop?

@dsmiley
dsmiley requested a review from mlbiscoc September 11, 2026 01:14
@mkhludnev

Copy link
Copy Markdown
Member Author

at least this patch let to disable metrics and it let me pass the benchmark for #4749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants