SOLR-18414: Randomize use of QueryLimits in all tests. - #4894
Open
sigram wants to merge 4 commits into
Open
Conversation
Contributor
Please always keep the JIRA link template. This way, as a reviewer, I merely click it instead of copy it and then clumsily manually make my way over to JIRA to search |
dsmiley
reviewed
Sep 10, 2026
dsmiley
left a comment
dsmiley
left a comment
Contributor
There was a problem hiding this comment.
I'm hoping we can avoid adding to STCJ4; I see STC as it's successor. Yet I don't want to see STC become the mess that STCJ4 has become. Adding yet another obscure mechanism (times 100 mechanisms...).
Could this be a Rule in its own file thats included... and then a test can choose to call some static method on it to turn it off when it's a problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in Jira.