{!globalOrdinalsJoin ..}.. QParser - single index, single field - #4881
Open
mkhludnev wants to merge 2 commits into
Open
{!globalOrdinalsJoin ..}.. QParser - single index, single field#4881mkhludnev wants to merge 2 commits into
{!globalOrdinalsJoin ..}.. QParser - single index, single field#4881mkhludnev wants to merge 2 commits into
Conversation
Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
{!globalOrdinalsJoin ..}.. QParser - single index, single field
Contributor
|
Surely this is JIRA worthy |
dsmiley
reviewed
Sep 8, 2026
dsmiley
left a comment
Contributor
There was a problem hiding this comment.
Why are you thinking that this is its own parser? Is it too different to fit into {!join ?
Contributor
There was a problem hiding this comment.
I really question that this parser deserves a dedicated page. I think it makes sense more sense to have one page on all our join queries.
Member
Author
There was a problem hiding this comment.
I think so. It has a different parameters: it's a single field, single index, an let to filter outer side - so, it deserves a separate parser, rather than overload existing one.
I've got your point about the doc page, I'll put on existing one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18441
Description
Bring Luncen JoinUtils global ordinals join. Limited to single index, single field - both sides.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.