Skip to content

{!globalOrdinalsJoin ..}.. QParser - single index, single field - #4881

Open
mkhludnev wants to merge 2 commits into
apache:mainfrom
mkhludnev:copilot/create-globalordinalsjoin-qparser
Open

{!globalOrdinalsJoin ..}.. QParser - single index, single field#4881
mkhludnev wants to merge 2 commits into
apache:mainfrom
mkhludnev:copilot/create-globalordinalsjoin-qparser

Conversation

@mkhludnev

@mkhludnev mkhludnev commented Sep 6, 2026

Copy link
Copy Markdown
Member

https://issues.apache.org/jira/browse/SOLR-18441

Description

Bring Luncen JoinUtils global ordinals join. Limited to single index, single field - both sides.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

Co-authored-by: mkhludnev <807522+mkhludnev@users.noreply.github.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation tests cat:search labels Sep 6, 2026
@mkhludnev mkhludnev changed the title Implement globalOrdinalsJoin QParser with tests and documentation {!globalOrdinalsJoin ..}.. QParser - single index, single field Sep 7, 2026
@dsmiley

dsmiley commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Surely this is JIRA worthy

@dsmiley dsmiley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you thinking that this is its own parser? Is it too different to fit into {!join ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really question that this parser deserves a dedicated page. I think it makes sense more sense to have one page on all our join queries.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. It has a different parameters: it's a single field, single index, an let to filter outer side - so, it deserves a separate parser, rather than overload existing one.
I've got your point about the doc page, I'll put on existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:search documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants