fix: include online gRPC subscriptions in topic-based admin queries - #11233
Open
3219378872 wants to merge 1 commit into
Open
3219378872 wants to merge 1 commit into
3219378872 wants to merge 1 commit into
Conversation
Author
|
The seven pull-request workflows for head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #11232.
Brief Description
A newly connected gRPC SimpleConsumer can be visible in group-based Proxy Admin subscription queries but absent from topic-based queries until the broker has a consumer offset for it. Topic-only group discovery previously consulted only broker registrations/offsets, so it never reached the existing Proxy-side connection merge for this group.
Include the Proxy consumer manager's topic groups in
resolveGroups, deduplicating them with the broker result. Existing broker discovery, group-only requests, topic filtering, and discovery-error behavior remain intact; a missing Proxy consumer manager keeps broker-only behavior.How Did You Test This Change?
RemoteChannelregistration, source deduplication, broker-only groups, unrelated topics, combined filters, absent consumer manager, and broker discovery errors. Checkstyle and SpotBugs passed in the normal Maven lifecycle.rocketmq-client-java:5.2.2SimpleConsumer in a separate JVM. Before any receive/ack, all four RPCs returnedOK; the original implementation returned one subscription by group and zero by topic for both List/Describe. The same fixture with the fix returns one in all four queries.RemoteChannelcomponent regression, not claimed as a live multi-Proxy test.mvn -B -ntp -pl proxy -am \ -Dtest=ProxyAdminTopicDiscoveryTest,ProxyAdminGrpcServiceTest,ProxyAdminAuthInterceptorTest,AdminModelConverterTest,DefaultAdminServiceTest,ProxyConfigTest \ -Dsurefire.failIfNoSpecifiedTests=false testRaw test results, pinned SDK fixture, and original/fixed runtime logs. Validation used Temurin 8u504 and Maven 3.9.9. This is an isolated local runtime test, not a production deployment or full-project test claim. Prepared with Codex assistance.