Conversation
Author
|
Thanks for the queue time, but I'm closing this in favor of #11202, which was opened two days earlier and addresses the same overflow issue. No point making the maintainers review the same fix twice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
#10850
Brief Description
Description
Several mqadmin comparators subtract long values and cast the result to int. Consumer lag, tag counts, and message store timestamps can therefore be ordered incorrectly once their difference exceeds the int range.
Affected commands include consumerProgress, printMessageByQueue, and queryMsgByUniqueKey.
Expected behavior
Use overflow-safe long comparison so command output remains correctly ordered for large values.
How Did You Test This Change?
PASSED: wsl -e bash scripts/gate-rocketmq.sh
补充说明
背景
Description
Several mqadmin comparators subtract long values and cast the result to int. Consumer lag, tag counts, and message store timestamps can therefore be ordered incorrectly once their difference exceeds the int range.
Affected commands include consumerProgress, printMessageByQueue, and queryMsgByUniqueKey.
Expected behavior
Use overflow-safe long comparison so command output remains correctly ordered for large values.
相关 Issue:#10850
变更内容
验证
PASSED: wsl -e bash scripts/gate-rocketmq.sh
检查清单