[ISSUE #10831] fix(store): handle minimum hash index in compaction offset map - #11209
Open
beautyarbutin wants to merge 1 commit into
Open
beautyarbutin wants to merge 1 commit into
beautyarbutin wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11209 +/- ##
=============================================
- Coverage 49.66% 49.58% -0.09%
+ Complexity 14332 14305 -27
=============================================
Files 1390 1390
Lines 103190 103190
Branches 13493 13493
=============================================
- Hits 51250 51163 -87
- Misses 45763 45832 +69
- Partials 6177 6195 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
CompactionLog.OffsetMappreviously usedMath.abs(index) % capacityto select a bucket. ForInteger.MIN_VALUE,Math.absremains negative and can produce an invalid negativeByteBufferposition.Use
Math.floorMod(index, capacity)so every hash maps to a valid non-negative bucket. A deterministicMessageDigestregression test producesInteger.MIN_VALUEand verifies bothputandgetpaths.This follows up on #10841, which was closed without being merged.
How Did You Test This Change?
mvn -B -ntp -pl store -am -DskipITs -Dtest=OffsetMapTest -Dsurefire.failIfNoSpecifiedTests=false -Dspotbugs.skip=true testOffsetMapTest: 3 tests passed