RANGER-5523: replace jersey-bundle dependency with jersey-client and jersey-core in plugins#882
Open
mneethiraj wants to merge 4 commits intoapache:masterfrom
Open
RANGER-5523: replace jersey-bundle dependency with jersey-client and jersey-core in plugins#882mneethiraj wants to merge 4 commits intoapache:masterfrom
mneethiraj wants to merge 4 commits intoapache:masterfrom
Conversation
…jersey-core in plugins
mneethiraj
requested review from
Copilot,
dhavalshah9131,
kumaab,
mehulbparikh,
pradeepagrawal8184 and
rameeshm
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Ranger plugin packaging to avoid using the monolithic Jersey 1 jersey-bundle by switching to more granular Jersey artifacts, while also making several assembly descriptors pin Jersey coordinates explicitly.
Changes:
- Add a new
${jsr311-api.version}property at the root build level. - Replace
com.sun.jersey:jersey-bundlewithcom.sun.jersey:jersey-client+com.sun.jersey:jersey-corein some plugin/module dependency and assembly definitions. - Update multiple distro assembly descriptors to use explicit
groupId:artifactId:jar:versioncoordinates for Jersey artifacts.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Adds jsr311-api.version property for packaging/assembly use. |
| agents-common/pom.xml | Replaces jersey-bundle with jersey-client + jersey-core in shared plugin common deps. |
| hbase-agent/pom.xml | Removes jsr311-api exclusion from jersey-client while keeping it on jersey-core. |
| distro/src/main/assembly/usersync.xml | Pins jersey-bundle include to an explicit jar/version coordinate. |
| distro/src/main/assembly/storm-agent.xml | Switches Storm agent packaging from jersey-bundle to jersey-client + jersey-core. |
| distro/src/main/assembly/sample-client.xml | Pins jersey-bundle include to an explicit jar/version coordinate. |
| distro/src/main/assembly/ranger-tools.xml | Pins jersey-bundle include to an explicit jar/version coordinate. |
| distro/src/main/assembly/plugin-trino.xml | Removes server-related Jersey includes and adds jersey-client + jersey-core (+ jersey-json). |
| distro/src/main/assembly/plugin-presto.xml | Removes server-related Jersey includes and adds jersey-client + jersey-core (+ jersey-json). |
| distro/src/main/assembly/plugin-ozone.xml | Replaces prior Jersey includes with jersey-client + jersey-core in multiple dependency lists. |
| distro/src/main/assembly/plugin-kafka.xml | Replaces jersey-bundle with jersey-client + jersey-core in plugin impl packaging. |
| distro/src/main/assembly/plugin-elasticsearch.xml | Replaces jersey-bundle with jersey-client + jersey-core in plugin impl packaging. |
| distro/src/main/assembly/plugin-atlas.xml | Replaces jersey-bundle with jersey-client + jersey-core in plugin impl packaging. |
| distro/src/main/assembly/plugin-solr.xml | Replaces jersey-bundle with jersey-client + jersey-core and explicitly includes jsr311-api. |
| distro/src/main/assembly/kms.xml | Pins jersey-bundle include to an explicit jar/version coordinate. |
| distro/src/main/assembly/admin-web.xml | Adds an explicit jersey-bundle include to the embedded webserver lib set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 25 out of 25 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. RANGER-XXXX: Fix a typo in YYY))
How was this patch tested?