Refactor splitPart function to reduce memory allocation#17585
Draft
rimijoker wants to merge 1 commit intoapache:masterfrom
Draft
Refactor splitPart function to reduce memory allocation#17585rimijoker wants to merge 1 commit intoapache:masterfrom
rimijoker wants to merge 1 commit intoapache:masterfrom
Conversation
dd2d5b0 to
1a1fb12
Compare
1a1fb12 to
fce2361
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
splitPartto reduce memory allocations during string parsing/splitting operations.Motivation
The previous implementation of
splitPartcreated many short-lived intermediate objects (substrings / temporary buffers), which increased GC pressure and decreased throughput under high load. This refactor reduces those allocations to improve performance and memory efficiency in hot code paths.What changed
splitPartto avoid creating intermediateStringobjects and temporary buffers where possible.splitPart.