PHOENIX-7769 Initialize and Close replication log groups as part of RS startup and shutdown#2465
Merged
tkhurana merged 1 commit intoapache:PHOENIX-7562-feature-newfrom May 7, 2026
Conversation
…S startup and shutdown
Contributor
Author
|
@Himanshu-g81 fixed the flapper test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReplicationLogGroupinstances during RS startup (prewarm phase) when synchronous replication is enabled, so they are ready before the first mutation arrives.ReplicationLogGroupinstances belonging to a server during RS shutdown via a newReplicationLogGroup.closeAll(serverName)method.serverNamecapture from the test subclass into the parentPhoenixRegionServerEndpoint, removing redundant code.ReplicationLogDiscoveryTestby injecting an advancing clock so rename timestamps are always strictly before the threshold on the next loop iteration.ReplicationLogBaseTestto support configurable aligned vs full-round initial rotation delay, enablingReplicationLogDiscoveryForwarderTestto use production-aligned rotation.Test plan
ReplicationLogGroupTest,ReplicationLogDiscoveryTest,ReplicationLogDiscoveryForwarderTestClosing all ReplicationLogGroup instances