Introduce implementation for FileType#3608
Open
brkyvz wants to merge 1 commit into
Open
Conversation
divjotarora
suggested changes
Jun 11, 2026
| } else if (!LogicalTypeAnnotation.FileLogicalTypeAnnotation.OPTIONAL_FIELD_NAMES.contains(fieldName)) { | ||
| throw new IllegalArgumentException( | ||
| "FILE type group '" + name + "' contains unrecognized field '" + fieldName | ||
| + "'. Valid fields are: path, size, offset, etag"); |
Contributor
There was a problem hiding this comment.
nit: stringify FileLogicalTypeAnnotation.OPTIONAL_FIELD_NAMES and use it in the error to avoid drift if we add new fields?
| } | ||
| } | ||
|
|
||
| private static void validateFileTypeFields(String name, List<Type> fields) { |
Contributor
There was a problem hiding this comment.
Where do we validate:
- If
offsetis present,sizemust be present offsetandsizemust be non-negative (note spec doesn't technically sayoffsetmust be >= 0, but I left a suggestion on that change to add it
Contributor
There was a problem hiding this comment.
We should add tests for validity of size/offset fields, both their values (>= 0) and valid/invalid combinations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Introduces the reference implementation for the new LogicalTypeAnnotation File as discussed in this design document
What changes are included in this PR?
Introduces a new LogicalTypeAnnotation called FILE. It enforces that a group with this type annotation have the following fields by name:
Are these changes tested?
Yes, unit tested
Are there any user-facing changes?
Introduces a new LogicalTypeAnnotation called FILE