[rest] Make RESTTokenFileIO cache maximum size configurable - #9528
Open
tonymtu wants to merge 1 commit into
Open
[rest] Make RESTTokenFileIO cache maximum size configurable#9528tonymtu wants to merge 1 commit into
tonymtu wants to merge 1 commit into
Conversation
ArnavBalyan
reviewed
Sep 1, 2026
ArnavBalyan
left a comment
ArnavBalyan
left a comment
Member
There was a problem hiding this comment.
Thanks! It seems the current PR is a no op, should this be wired up to a config or an upstream caller leveraging the new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
RESTTokenFileIOuses a cache with a fixed maximum size of 1000. When the cache reaches this limit, aFileIOthat is still in use may be evicted and closed prematurely.This PR adds
RESTTokenFileIO#setFileIOCacheMaximumSize(long), allowing applications to configure the cache size during initialization according to their workloads.To keep this change focused, this PR does not introduce reference counting or change the
FileIOlifecycle management.Tests
Added a unit test to verify that the maximum cache size can be updated.