[pvfs] Set working directory to the catalog root in PaimonVirtualFileSystem - #9507
Open
thswlsqls wants to merge 1 commit into
Open
[pvfs] Set working directory to the catalog root in PaimonVirtualFileSystem#9507thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
…System Generated-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
fix #9506
x.csvsucceeds today and throwsIOExceptionafter this change. That success writes into a table the user never named, and which table is non-deterministic — the Hadoop FileSystem cache key is scheme+authority+ugi.initialize()tookworkingDirectoryfrom the raw URI Hadoop passes in while normalizingthis.uritoscheme://authority/. Reorder so it derives from the normalized catalog root. The self-contradiction dates to [Feature] Implement Paimon Virtual Filesystem #5916.docs/docs/concepts/rest/pvfs.mdlines 61-62.Tests
VirtualFileSystemTest#testWorkingDirectoryIsCatalogRoot, inherited by both subclasses: the working directory equals the catalog root, and a relative-pathcreatelands in the table it names.mvn -pl paimon-vfs/paimon-vfs-hadoop clean install— 29 tests pass. No existing test initializes with a path component (MockRestVirtualFileSystemTestL119,MockRestNoCacheVirtualFileSystemTestL47), so the 27 pre-existing tests stay green.