[core] Support empty dirs cleaning without bucket sub dir in orphan files cleanup#7295
Open
XiaoHongbo-Hope wants to merge 1 commit intoapache:masterfrom
Open
[core] Support empty dirs cleaning without bucket sub dir in orphan files cleanup#7295XiaoHongbo-Hope wants to merge 1 commit intoapache:masterfrom
XiaoHongbo-Hope wants to merge 1 commit intoapache:masterfrom
Conversation
ea53d8f to
a885856
Compare
clean code clean code refactor to list empty partition dirs when listPaimonFileDirs revert orphan files clean change in spark update test case after refactor optimize test case to cover emptyNonLeafPartitionPath optimize test case to cover emptyNonLeafPartitionPath add test case about non-empty dir delete add log for empty partition clean clean empty partition dirs with age safeguard
a885856 to
ca36d91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/Problem
Currently, OrphanFilesClean does not clean empty partition directories with no bucket subdirectories, causing a lot of empty dirs left.
Example Scenario:
Note: All belows are empty dirs.
Before:
After:
Tests
OrphanFilesCleanTestRemoveOrphanFilesActionITCaseBaseLocalOrphanFilesCleanTestAPI and Format
Documentation
Generative AI tooling
UT is coauthored by Cursor